Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(validate): provide validate error in cause #890

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

JianJroh
Copy link
Contributor

@JianJroh JianJroh commented Sep 30, 2024

To be more friendly to catch third-party errors with cause

@JianJroh JianJroh requested a review from pi0 as a code owner September 30, 2024 04:19
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.45%. Comparing base (a58d7c9) to head (094449c).
Report is 197 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #890      +/-   ##
==========================================
+ Coverage   77.83%   79.45%   +1.62%     
==========================================
  Files          47       43       -4     
  Lines        4286     3291     -995     
  Branches      611      796     +185     
==========================================
- Hits         3336     2615     -721     
+ Misses        933      673     -260     
+ Partials       17        3      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 added the v2 label Nov 29, 2024
@pi0 pi0 merged commit 4de8e13 into unjs:main Dec 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants